Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement ADR-017 subspace grant #1071

Merged
merged 85 commits into from
Feb 7, 2023

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Jan 18, 2023

Description

This PR implements ADR-017 subspace grant feature.

Overseeds: #1057


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dadamu dadamu requested a review from a team as a code owner January 18, 2023 10:47
@dadamu dadamu marked this pull request as draft January 18, 2023 10:47
@github-actions github-actions bot added x/CLI x/subspaces Issue on the x/subspaces module labels Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 80.52% // Head: 80.70% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (718f734) compared to base (58676fd).
Patch coverage: 83.94% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   80.52%   80.70%   +0.17%     
==========================================
  Files         180      185       +5     
  Lines       15804    16565     +761     
==========================================
+ Hits        12726    13368     +642     
- Misses       2522     2610      +88     
- Partials      556      587      +31     
Impacted Files Coverage Δ
x/subspaces/types/permissions.go 77.77% <ø> (ø)
x/subspaces/types/codec.go 55.88% <43.75%> (-3.74%) ⬇️
x/subspaces/wasm/querier.go 56.52% <53.84%> (-0.79%) ⬇️
x/subspaces/types/genesis.go 96.00% <70.83%> (-4.00%) ⬇️
x/subspaces/legacy/v5/store.go 81.63% <72.72%> (-7.66%) ⬇️
x/subspaces/types/models_feegrant.go 78.94% <78.94%> (ø)
x/subspaces/keeper/alias_functions.go 80.76% <79.54%> (-0.49%) ⬇️
x/subspaces/keeper/grpc_query.go 82.69% <79.66%> (-1.21%) ⬇️
x/subspaces/types/msgs_feegrant.go 84.21% <84.21%> (ø)
x/subspaces/keeper/msg_server_feegrant.go 90.00% <90.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the kind/adr An issue or PR relating to an architectural decision record label Jan 19, 2023
@github-actions github-actions bot added the kind/build Related to the build of the project label Jan 24, 2023
@dadamu dadamu requested a review from RiccardoM January 30, 2023 09:12
@dadamu dadamu force-pushed the paul/DCD-184/implement-revise-subspace-grant branch from 4f13e3c to ce6f8fa Compare January 30, 2023 09:27
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait @manu0466 review as well just to make sure I didn't miss anything

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jan 31, 2023
Co-authored-by: Manuel <manuel.turetta94@gmail.com>
@dadamu dadamu requested a review from manu0466 February 6, 2023 17:03
@github-actions github-actions bot removed the kind/build Related to the build of the project label Feb 7, 2023
@mergify mergify bot merged commit 85ce043 into master Feb 7, 2023
@mergify mergify bot deleted the paul/DCD-184/implement-revise-subspace-grant branch February 7, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/adr An issue or PR relating to an architectural decision record x/CLI x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants