-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate interchain account #1082
Conversation
app/app.go
Outdated
icaControllerIBCModule := ibcfee.NewIBCMiddleware( | ||
icacontroller.NewIBCMiddleware(nil, app.ICAControllerKeeper), | ||
app.IBCFeeKeeper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no public ICA auth module available at the moment, so set it nil
as it is not enabled, See:
https://ibc.cosmos.network/main/apps/interchain-accounts/integration.html#disabling-controller-chain-functionality
The demo of the controller can be found the following repo, we should implement our own or waiting for the public one released.
https://github.com/cosmos/interchain-accounts-demo
d355c48
to
5e41748
Compare
5e41748
to
2fb4b5f
Compare
Codecov ReportBase: 80.46% // Head: 80.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
+ Coverage 80.46% 80.52% +0.05%
==========================================
Files 180 180
Lines 15757 15804 +47
==========================================
+ Hits 12679 12726 +47
Misses 2522 2522
Partials 556 556
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
This PR integrates ICS27 interchain account module to Desmos, the integration follows this guide.
Depends-On: #1081
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change