Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate interchain account #1082

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Feb 3, 2023

Description

This PR integrates ICS27 interchain account module to Desmos, the integration follows this guide.

Depends-On: #1081


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dadamu dadamu requested a review from a team as a code owner February 3, 2023 09:39
@github-actions github-actions bot added kind/build Related to the build of the project x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/relationships x/subspaces Issue on the x/subspaces module labels Feb 3, 2023
app/app.go Outdated
Comment on lines 669 to 672
icaControllerIBCModule := ibcfee.NewIBCMiddleware(
icacontroller.NewIBCMiddleware(nil, app.ICAControllerKeeper),
app.IBCFeeKeeper)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no public ICA auth module available at the moment, so set it nil as it is not enabled, See:
https://ibc.cosmos.network/main/apps/interchain-accounts/integration.html#disabling-controller-chain-functionality

The demo of the controller can be found the following repo, we should implement our own or waiting for the public one released.
https://github.com/cosmos/interchain-accounts-demo

@dadamu dadamu force-pushed the paul/integrate-interchain-account branch 3 times, most recently from d355c48 to 5e41748 Compare February 3, 2023 19:27
@RiccardoM RiccardoM force-pushed the paul/integrate-interchain-account branch from 5e41748 to 2fb4b5f Compare February 7, 2023 19:52
@github-actions github-actions bot removed kind/build Related to the build of the project x/subspaces Issue on the x/subspaces module x/relationships x/profiles Module that allows to create and manage decentralized social profiles x/CLI labels Feb 7, 2023
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 80.46% // Head: 80.52% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (04b86da) compared to base (94a5c4a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   80.46%   80.52%   +0.05%     
==========================================
  Files         180      180              
  Lines       15757    15804      +47     
==========================================
+ Hits        12679    12726      +47     
  Misses       2522     2522              
  Partials      556      556              
Impacted Files Coverage Δ
app/app.go 89.46% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 58676fd into master Feb 7, 2023
@mergify mergify bot deleted the paul/integrate-interchain-account branch February 7, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants