feat!: implement ADR 21: Subspace specific custom fee tokens

[dadamu]

Description

This PR implements ADR-21: Subspace specific custom fee tokens feature.

Closes: DCD-312

Depends-On: #1135
Depends-On: #1139

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Patch coverage: 83.22% and project coverage change: -0.46 ⚠️

Comparison is base (f0b03d0) 80.77% compared to head (cecf756) 80.32%.

❗ Current head cecf756 differs from pull request most recent head 5f0d45f. Consider uploading reports for the commit 5f0d45f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   80.77%   80.32%   -0.46%     
==========================================
  Files         193      190       -3     
  Lines       17159    16825     -334     
==========================================
- Hits        13861    13515     -346     
- Misses       2701     2716      +15     
+ Partials      597      594       -3     

Impacted Files	Coverage Δ
x/reactions/types/msgs.go	95.16% <0.00%> (-2.10%)	⬇️
x/reports/types/msgs.go	96.98% <0.00%> (-1.79%)	⬇️
x/subspaces/ante/fee.go	82.35% <0.00%> (ø)
x/subspaces/types/msgs_feegrant.go	82.47% <0.00%> (-1.74%)	⬇️
x/subspaces/types/msgs_treasury.go	93.75% <0.00%> (-3.03%)	⬇️
x/subspaces/types/msgs.go	94.70% <65.00%> (-2.88%)	⬇️
x/subspaces/types/codec.go	58.66% <85.71%> (+2.78%)	⬆️
x/subspaces/ante/tx_checker.go	100.00% <100.00%> (ø)
x/subspaces/keeper/keeper.go	100.00% <100.00%> (ø)
x/subspaces/keeper/msg_server.go	88.98% <100.00%> (+0.57%)	⬆️
... and 2 more

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dadamu]

@RiccardoM @manu0466 Rebased

[RiccardoM]

I'm not super familiar with on-chain gas prices, but I thought they were treated using the and logic. So if I have a min gas price of 0.01udsm,0.01ustar then to properly broadcast my transaction I have to pay fees in both tokens, and not either one of the two. Do you have any link for this to be checked out that we can paste here to remember this in the future?

[dadamu]

They are treated as or, so one of tokens reaches the min fees can broadcast properly, say, to send the message with 100 gas via the node with 0.01udsm, 0.01ustar min gas prices, 1udsm or 1ustar can pass the check.

Here is the reference:
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/x/auth/ante/validator_tx_fee.go#L38

[RiccardoM]

I'm not a big fan of this approach. Instead I think it would be better to:

1. Add another param inside the NewSubspace function to specify the fee tokens when creating the subspace. This is going to be useful when exporting/importing the genesis as well as inside tests.
2. Rename this method Update as we have done with the Post and Attachment type, to keep everything consistent.

Also, I'm doubting whether AllowedFeeTokens is the proper name. I think AdditionalFeeTokens might be better instead. The name AllowedFeeTokens might make people think that if I specify 0.01ustar then the star token is going to be then only one allowed, while the udsm should always be allowed anyway. Using AdditionalFeeTokens might make everything more easy to understand.

[dadamu]

I see, I use the SetAllowedFeeTokens since adding another param inside the NewSubspace will break hundreds of existing test codes, but yeah, it is better to have an additional field.

strongly agree with AdditionalFeeTokens is better.

[dadamu]

Finally, I used sed to add the new parameter quickly:

#!/bin/bash

dir="./x"

find "$dir" -type f -name "*.go" | while read -r file; do
    sed -i -E ':a;N;$!ba;s/NewSubspace\([^)]*time.UTC,/&\nnil,/g' "$file"
    echo "$file"
done

Is any other tools to make modifying codes quickly?

[RiccardoM]

I honestly don't know of any other tool that can easily update the code. I would have done it by hand 😓 Great job using sed 💯

[RiccardoM]

Great job 💯