Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing account number of account creation #1250

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Sep 28, 2023

Description

Closes: #XXXX
This PR fixes the issue that account has no account number since using authtypes.NewBaseAccountWithAddress. To solve it, we should use AccountKeeper.NewAccountWithAddress instead, to make sure account number is set.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
x/profiles/keeper/msg_server_dtag_transfers.go 77.27% <100.00%> (ø)
x/profiles/keeper/msgs_server_profile.go 80.26% <100.00%> (-3.08%) ⬇️

📢 Thoughts on this report? Let us know!.

@dadamu dadamu marked this pull request as ready for review September 28, 2023 08:29
@dadamu dadamu requested a review from a team as a code owner September 28, 2023 08:29
@dadamu dadamu force-pushed the paul/fix-dtag-receiver-account-creating branch from 57de5d3 to cd3076e Compare September 28, 2023 08:59
@RiccardoM RiccardoM merged commit d56fbd9 into master Sep 28, 2023
34 checks passed
@RiccardoM RiccardoM deleted the paul/fix-dtag-receiver-account-creating branch September 28, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants