Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move posts' const to chain params #204

Merged
merged 13 commits into from Jul 1, 2020
Merged

Move posts' const to chain params #204

merged 13 commits into from Jul 1, 2020

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Jun 29, 2020 •
edited

Description

This PR move posts' const into chain params in order to let them be changed through proposal and queried easily from clients.
Close #172 .
Close #205 .

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@leobragaz leobragaz added kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module Status:WIP labels Jun 29, 2020
@leobragaz leobragaz added this to the v0.8.0 milestone Jun 29, 2020
@leobragaz leobragaz self-assigned this Jun 29, 2020
@leobragaz leobragaz added this to In progress in Desmos via automation Jun 29, 2020
leobragaz
leobragaz commented Jun 30, 2020
View reviewed changes
Copy link
Contributor Author

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-reviewed

@leobragaz leobragaz requested a review from RiccardoM June 30, 2020 10:37
@leobragaz
revert posts file organization
c629f6a 
added migrate `v0.8.0`
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited

Codecov Report

Merging #204 into master will increase coverage by 0.53%.
The diff coverage is 86.61%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   83.23%   83.76%   +0.53%     
==========================================
  Files          75       78       +3     
  Lines        2815     2902      +87     
==========================================
+ Hits         2343     2431      +88     
+ Misses        407      403       -4     
- Partials       65       68       +3

RiccardoM
RiccardoM suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall implementation looks good. There are some things I would change but otherwise it's ready to be merged 💯

x/posts/internal/keeper/querier_test.go Outdated Show resolved Hide resolved
x/posts/internal/types/params.go Outdated Show resolved Hide resolved
x/posts/internal/types/params.go Outdated Show resolved Hide resolved
x/posts/legacy/v0.8.0/types.go Outdated Show resolved Hide resolved
x/posts/legacy/v0.8.0/migrate_test.go Outdated Show resolved Hide resolved
x/posts/legacy/v0.8.0/migrate_test.go Show resolved Hide resolved
x/posts/legacy/v0.8.0/migrate_test.go Outdated Show resolved Hide resolved
x/posts/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/posts/internal/keeper/handler.go Outdated Show resolved Hide resolved
x/posts/internal/keeper/handler.go Outdated Show resolved Hide resolved
@leobragaz leobragaz requested a review from RiccardoM July 1, 2020 11:04
RiccardoM
RiccardoM approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiccardoM RiccardoM merged commit 9bc3533 into master Jul 1, 2020
@RiccardoM RiccardoM deleted the leonardo/post-consts-to-chain-params branch July 1, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees

@leobragaz leobragaz

Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module
Projects
No open projects
Desmos
  
In progress
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Update CHANGELOG Move the current posts constants to chain parameters
2 participants
@leobragaz @RiccardoM