Various improvements #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… riccardo/module-separation
- Improved the posts events - Replaced all the time.Time instances with block heights (works towards #23)
- Replaced the creation time with block height
RiccardoM
added
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## develop #37 +/- ##
============================================
+ Coverage 41.64% 61.18% +19.54%
============================================
Files 4 13 +9
Lines 341 541 +200
============================================
+ Hits 142 331 +189
+ Misses 199 192 -7
- Partials 0 18 +18
Continue to review full report at Codecov.
|
kwunyeung
reviewed
Nov 7, 2019
| Expiry: msg.Created.Add(time.Minute * 14400), | ||
| SessionID: keeper.GetLastSessionID(ctx).Next(), | ||
| Created: ctx.BlockHeight(), | ||
| Expiry: ctx.BlockHeight() + 240, // 24 hours, counting a 6 secs block interval |
There was a problem hiding this comment.
Nice one! May put this in genesis params later.
There was a problem hiding this comment.
Opened #38 to have a better discussion there.
kwunyeung
reviewed
Nov 7, 2019
x/posts/internal/keeper/handler.go
Outdated
| case types.MsgLikePost: | ||
| return handleMsgLike(ctx, keeper, msg) | ||
| default: | ||
| errMsg := fmt.Sprintf("Unrecognized Magpie Msg type: %v", msg.Type()) |
There was a problem hiding this comment.
This error message should be updated.
kwunyeung
reviewed
Nov 7, 2019
x/magpie/internal/keeper/querier.go
Outdated
| abci "github.com/tendermint/tendermint/abci/types" | ||
| ) | ||
|
|
||
| // query endpoints supported by the magpie Querier | ||
| const ( | ||
| QueryPost = "post" | ||
| QueryLike = "like" | ||
| QuerySession = "testSession" |
There was a problem hiding this comment.
It looks this would give error when query sessions/ endpoint.
kwunyeung
reviewed
Nov 7, 2019
kwunyeung
requested changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
magpiemodule intomagpieandposts(closes Split the magpie module #26)Checklist
Files changedin the Github PR explorer