Add PostComments paginated query method
#510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 84.94% 84.93% -0.01%
==========================================
Files 89 89
Lines 4284 4296 +12
==========================================
+ Hits 3639 3649 +10
- Misses 484 485 +1
- Partials 161 162 +1
Continue to review full report at Codecov.
|
…post-comments-query
leobragaz
requested changes
Jun 23, 2021
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
RiccardoM
reviewed
Jun 25, 2021
| @@ -93,6 +93,11 @@ func (k msgServer) CreatePost(goCtx context.Context, msg *types.MsgCreatePost) ( | |||
| return nil, sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, | |||
| "post with id %s does not allow comments", parentPost.PostID) | |||
| } | |||
|
|
|||
| if parentPost.Subspace != post.Subspace { | |||
x/staging/posts/keeper/keeper.go
Outdated
| // nolint: interfacer | ||
| func (k Keeper) GetPostChildrenIDs(ctx sdk.Context, postID string) []string { | ||
| store := ctx.KVStore(k.storeKey) | ||
| func (k Keeper) GetPostCommentsIDs(ctx sdk.Context, postID string) []string { |
There was a problem hiding this comment.
I'm having a hard time understanding where this is used. Maybe we can delete it?
There was a problem hiding this comment.
I agree. It is only for test. Let me move it to test files or use another way in test.
| @@ -30,6 +30,23 @@ func (k Keeper) IteratePosts(ctx sdk.Context, fn func(index int64, post types.Po | |||
| } | |||
| } | |||
|
|
|||
| func (k Keeper) IterateCommentIDsByPost(ctx sdk.Context, postID string, fn func(index int64, commentID string) (stop bool)) { | |||
There was a problem hiding this comment.
I think this is only used inside GetPostCommentsIDs, which appears to be unused as well. Maybe we can delete this as well?
RiccardoM
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the implementation of #505.
Closes #505
CommentIDobject from protoPostCommentsquery methodPostCommentscmd functionChecklist
CHANGELOG.mdfile.Files changedin the Github PR explorer.