build(deps): upgrade to Cosmos v0.44.0 #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…cosmos-v0.43-upgrade � Conflicts: � go.mod � go.sum
RiccardoM
changed the title
dadamu
reviewed
Aug 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 75.59% 84.84% +9.25%
==========================================
Files 94 91 -3
Lines 4519 5392 +873
==========================================
+ Hits 3416 4575 +1159
+ Misses 960 606 -354
- Partials 143 211 +68
Continue to review full report at Codecov.
|
dadamu
force-pushed
the
riccardo/cosmos-v0.43-upgrade
branch
from
5e439fa
to
1936e81
Compare
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM
changed the title
RiccardoM
commented
Sep 7, 2021
| @@ -30,6 +30,9 @@ message PageRequest { | |||
| // count_total is only respected when offset is used. It is ignored when key | |||
| // is set. | |||
| bool count_total = 4; | |||
|
|
|||
| // reverse is set to true if results are to be returned in the descending order. | |||
| bool reverse = 5; | |||
There was a problem hiding this comment.
Didn't see this was added. Nice!
leobragaz
reviewed
Sep 7, 2021
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
|
I would like to ask both of you @bragaz @dadamu to approve this PR (I can't since I'm the one that made it) to make sure we all agree on the changed before merging it. Please do this after a detailed review |
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM
force-pushed
the
riccardo/cosmos-v0.43-upgrade
branch
from
c2dae22
to
82c8c25
Compare
dadamu
reviewed
Sep 8, 2021
leobragaz
reviewed
Sep 8, 2021
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
leobragaz
approved these changes
Sep 9, 2021
dadamu
reviewed
Sep 9, 2021
dadamu
approved these changes
Sep 9, 2021
RiccardoM
changed the title
…cosmos-v0.43-upgrade � Conflicts: � go.mod � go.sum
github-actions
bot
added
kind/build
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Desmos to use Cosmos v0.44.0.
Some tests might need some fixes.
Closes #585
Checklist
CHANGELOG.mdfile.Files changedin the Github PR explorer.