build(deps): bump Band Protocol to v2.3.1 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
github-actions
bot
added
kind/build
RiccardoM
changed the title
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 75.59% 84.23% +8.64%
==========================================
Files 94 91 -3
Lines 4519 6624 +2105
==========================================
+ Hits 3416 5580 +2164
+ Misses 960 833 -127
- Partials 143 211 +68
Continue to review full report at Codecov.
|
…upgrade-band � Conflicts: � go.sum
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM
commented
Sep 20, 2021
| @@ -59,11 +59,11 @@ message OracleRequest { | |||
| option (gogoproto.equal) = true; | |||
|
|
|||
| // ID is the ID of the request | |||
| int64 id = 1 | |||
| uint64 id = 1 | |||
There was a problem hiding this comment.
All these int are now uint inside Band code
| @@ -107,13 +107,9 @@ message OracleParams { | |||
| // the oracle script | |||
| uint64 execute_gas = 5 [ (gogoproto.moretags) = "yaml:\"execute_gas\"" ]; | |||
|
|
|||
| // FeePayer represents the key of the account that is going to pay for oracle | |||
| // fees if needed | |||
| string fee_payer = 6 [ (gogoproto.moretags) = "yaml:\"fee_payer\"" ]; | |||
There was a problem hiding this comment.
This is no longer used by Band Protocol
| @@ -35,7 +35,7 @@ func (s *IntegrationTestSuite) TestCmdQueryApplicationsLinks() { | |||
| types.NewData("reddit", "reddit-user"), | |||
| types.ApplicationLinkStateInitialized, | |||
| types.NewOracleRequest( | |||
| -1, | |||
| 0, | |||
There was a problem hiding this comment.
uint does not support negative values, so the default one will be 0 now
leobragaz
reviewed
Sep 20, 2021
.changeset/entries/397a12a6296b6f866be6f048c1be9e500e8a3a570c96b1dec4b1cd451ae142f9.yaml
Outdated
Show resolved
Hide resolved
| ErrValidatorAlreadyReported = sdkerrors.Register(ModuleName, 11, "validator already reported") | ||
| ErrInvalidReportSize = sdkerrors.Register(ModuleName, 12, "invalid report size") | ||
| ErrReporterNotAuthorized = sdkerrors.Register(ModuleName, 13, "reporter not authorized") | ||
| ErrEditorNotAuthorized = sdkerrors.Register(ModuleName, 14, "editor not authorized") |
There was a problem hiding this comment.
missing the 15 or is It ok?
There was a problem hiding this comment.
@bragaz These files are automatically downloaded from the Band Protocol repository, so I think it's fine. We only use part of them anyway inside our codebase
…6b1dec4b1cd451ae142f9.yaml Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
leobragaz
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Band Protocol dependencies to version v2.3.1, which is going to be the Band version used inside their new testnet as well as upcoming mainnet. This version relies on Cosmos v0.44.0.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change