substituteKeyboardEvents config option
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets API consumers override the keyboard events abstraction with a wrapper around saneKeyboardEvents() that can intercept events and ignore them or do stuff like insert `ans` before a `+` is typed.
Requested by @mikehaverstock: #27 (comment) It really should've in the first place, as the source-of-truth on keyboard/textare events. -- Previously listened for `copy` event on textarea for both editable fields and static math, now only for static math (which doesn't use `saneKeyboardEvents()`), for editable fields the `cut` and `copy` handlers are just methods on the controller object.
...like paste and typedText. Factor out and use checkTextareaOnce(). Note: - can't just setTimeout() because of the race condition of typing really fast after cut/copy (not theoretical: #37) - can't just checkTextareaFor() or cut/copy handlers would be called multiple times (input event, keyup event, timeout etc) laughinghan@005eca4#commitcomment-17697165
|
@han - It looks like this PR broke |
|
I wouldn't be opposed to moving copy back to where it was to get things working ASAP. That's not an event we need to observe, really. |
laughinghan
added a commit
that referenced
this pull request
Jun 10, 2016
|
@mikehaverstock: whoops thanks fixed by #35 Sorry I didn't see this, @han doesn't ping me on GitHub, here I'm @laughinghan |
mikehaverstock
pushed a commit
that referenced
this pull request
Jun 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets API consumers override the keyboard events abstraction with a
wrapper around
saneKeyboardEvents()that can intercept events and ignorethem or do stuff like insert
ansbefore a+is typed.