Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting outputs with linfa.plot_res #14

Closed
robmoss opened this issue Feb 27, 2024 · 1 comment
Closed

Plotting outputs with linfa.plot_res #14

robmoss opened this issue Feb 27, 2024 · 1 comment

Comments

@robmoss
Copy link

robmoss commented Feb 27, 2024

After running some examples (#13) I also have a few questions and comments about plotting the results:

  • The linfa.plot_res module is mentioned in README.md, but not anywhere in the online documentation (unless I've missed it). I think it's plausible that a user might look at the online documentation, but not the GitHub repository, so perhaps this module could be included in the online documentation?

  • I discovered that the folder name must end with a trailing slash, otherwise it raises an error:

    python -m linfa.plot_res -n trivial -i 25000 -f results
    Log file not found: resultstrivial/log.txt

    Line 162 of plot_res.py concatenates the folder and experiment names. Please consider using os.path.join() or pathlib.Path to construct file names.

@daneschi
Copy link
Member

Thank you for the comments!

  • I have added the "plot_res" module to the online documentation under "post-processing and plotting".
  • The "plot_res.py" file was edited to use os.path.join().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants