Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links of posts and communities in app #186

Closed
PassionateG1t opened this issue Jul 14, 2022 · 9 comments
Closed

Open links of posts and communities in app #186

PassionateG1t opened this issue Jul 14, 2022 · 9 comments
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request

Comments

@PassionateG1t
Copy link

Right now when someone links another post or a community, it redirects to the web. The ability to open them in the app itself would be useful.

@EdoSecco
Copy link

This should be implemented in the app system settings, but with the possibility to add custom URLs, let's say for every single Lemmy instance.
Alternatively - and that would be way better - it could be done via app updates, updating time by time the list of instances and adding the related URLs to the list.

@dessalines
Copy link
Member

Agree, this would be useful to have. But this requires a hardcoded list of URLs, so I would probably only add these for the most popular instances, and any others on request.

dessalines added a commit that referenced this issue Oct 4, 2022
- My phone still uses the browser for some reason, but FF shows a "open
  in app" dialog. Can't figure this one out. #186
- Fix constantly opening keyboard issue. Fixes #226
dessalines added a commit that referenced this issue Oct 4, 2022
* Adding deep links.

- My phone still uses the browser for some reason, but FF shows a "open
  in app" dialog. Can't figure this one out. #186
- Fix constantly opening keyboard issue. Fixes #226

* A few fixes

* Another fix.
@dessalines
Copy link
Member

These do appear to be working.

@EdoSecco
Copy link

If I try to open https://feddit.it/post/75565 the app goes to https://lemmy.ml/post/75565
Same for groups, https://lemmygrad.ml/c/starwars > https://lemmy.ml/c/starwars

Should I check something in order to have it working in the right way?

@dessalines
Copy link
Member

It can't use the right link unless your jerboa account is that server currently. I might be able to rework this but it'll pry be a while.

@0hCome0n
Copy link

0hCome0n commented Jun 2, 2023

I get the feeling constantly adding hardcoded instances to the deeplink support is going to get annoying, and yet as a user I would like to keep all my activity inside the app.

I've got the following instance requests

midwest.social
mander.xyz
slrpnk.net
lemmy.ca

Thanks!

I'm going to put in a feature request with the Android dev team to let the user add custom URLs inside the system settings.

@dessalines
Copy link
Member

It is definitely annoying. I think the way I'm going to handle it, is like other federated apps: just let the search box allow you to paste in urls, so you can view its representation in the app. Because this has been a mess to get working and maintain.

@twizmwazin twizmwazin added the enhancement New feature or request label Jun 7, 2023
@Dakkaron
Copy link

I'd like to have the option to open these links directly in the app without going through the system. Since Android 12 crippled the "open with" dialogue, it's hardly usable at all.

But since these internal links tend to follow their own link scheme, it shouldn't be too hard to not render them as a link that goes through the system, but instead opens directly in the app.

Maybe make this toggleable, but I am pretty sure there aren't many people who want to switch to the browser when they press a link to a Lemmy community inside Jerboa. I'm in the app already, so obviously I want to use the app.

@twizmwazin twizmwazin added the 4 - medium/high priority Issue needs to be fixed soon, does not break core functionality label Jun 14, 2023
@twizmwazin
Copy link
Contributor

Closing in favor of #524

@twizmwazin twizmwazin closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants