Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"internal" deeplinks should open in Jerboa, not in a browser #524

Open
2 of 3 tasks
oscarnylander opened this issue Jun 11, 2023 · 1 comment
Open
2 of 3 tasks

"internal" deeplinks should open in Jerboa, not in a browser #524

oscarnylander opened this issue Jun 11, 2023 · 1 comment
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request

Comments

@oscarnylander
Copy link
Contributor

  • Did you check to see if this issue already exists?
  • Is this only a single feature request? Do not put multiple feature requests in one issue.
  • Is this a question or discussion? Don't use this, use https://lemmy.ml/c/jerboa

** Describe the feature request below **

Currently, when tapping a link that is a Lemmy-link, the link opens in the browser. While handling links externally to open in the app is quite a bit more challenging due to the at build-time unknown Lemmy-hosts, we should be able to intercept link opening while inside the app, to load these Lemmy-links inside Jerboa.

Supported link types could be:

  • Community
  • Post
  • Comment in Post
  • User

Perhaps more that I can't think of right now.

@twizmwazin twizmwazin added 4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request labels Jun 14, 2023
@beatgammit
Copy link
Contributor

It looks like communities and users are already implemented.

So the only things left are comments and posts, and I think those could be done pretty easily. We already have permalink support, so it should be as easy as following the logic here to implement the rest.

This would probably be a good first issue for someone since there's already examples of what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants