Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox reply interactions missing #525

Closed
Stugist opened this issue Jun 11, 2023 · 12 comments · Fixed by #634
Closed

Inbox reply interactions missing #525

Stugist opened this issue Jun 11, 2023 · 12 comments · Fixed by #634
Labels
5 - high priority This issue affects core functionality and must be fixed ASAP bug Something isn't working

Comments

@Stugist
Copy link

Stugist commented Jun 11, 2023

** Jerboa Version **
0.0.33

Describe the bug
Buttons are missing below inbox rrplies

To Reproduce
Steps to reproduce the behavior:

  1. Go to inbox
  2. See error
    Screenshot_20230611_095403_Jerboa for Lemmy
@Stugist Stugist added the bug Something isn't working label Jun 11, 2023
@Stugist Stugist closed this as completed Jun 11, 2023
@Stugist Stugist reopened this Jun 11, 2023
@Stugist
Copy link
Author

Stugist commented Jun 11, 2023

Other folk are confirming on my post in c/Jerboa.
Accidentally clicked the wrong button with my damned sausage fingers, issue is not closed.

@Stugist
Copy link
Author

Stugist commented Jun 11, 2023

Not a bug, a feature. Inbox interaction collapse needs to be added to 0.0.33 update documentation as it's not currently mentioned.

@Stugist Stugist closed this as completed Jun 11, 2023
@0hCome0n
Copy link

The toggle for "show action bar by default fit comments" doesn't work for replies in your inbox. They're already collapsed by default regardless of the toggle. That's the real bug.

@twizmwazin twizmwazin reopened this Jun 12, 2023
@Riftr
Copy link

Riftr commented Jun 12, 2023

The toggle for "show action bar by default fit comments" doesn't work for replies in your inbox. They're already collapsed by default regardless of the toggle. That's the real bug.

It's a bit more than this as you can't show the controls at all currently. The only option you have is to press on the header of the inbox message that takes you to the top of the post that reply is buried in.

@Stugist
Copy link
Author

Stugist commented Jun 12, 2023

This is not true, currently if you long press in the space beside the username it expands the action bar.

@Riftr
Copy link

Riftr commented Jun 12, 2023

This is not true, currently if you long press in the space beside the username it expands the action bar.

Ah ha! You are correct but I could not figure this out and I thought I'd pressed everywhere that made sense at least.

@Stugist
Copy link
Author

Stugist commented Jun 12, 2023

Ah ha! You are correct but I could not figure this out and I thought I'd pressed everywhere that made sense at least.

It took a bunch of us over in c/Jerboa the better part of an hour to figure it out, don't feel bad.

@twizmwazin twizmwazin added the 5 - high priority This issue affects core functionality and must be fixed ASAP label Jun 14, 2023
@beatgammit
Copy link
Contributor

currently if you long press in the space beside the username it expands the action bar.

For me it collapses the entire post, not just the action bar, which doesn't seem to cause this.

Can you give the step-by-step process to reproduce this? I'm willing to look into fixing this, but I'm not sure how to reproduce. I think for now disabling the click next to the username while in the inbox makes the most sense, but I'm not sure if someone actually wants that feature. I use it a ton for collapsing comment threads, but not for inbox replies.

@0hCome0n
Copy link

Screenshot_20230614-003303~2

For me the action bar is closed by default in the inbox regardless of how the toggle in the settings is set.

Key for the image:

Top White: Post Title
Blue: Username
Green: Community
Bottom White: Comment
Brown/Gold Highlight: Active Area

For me, long pressing on the active area will expand and collapse the action bar.

Tapping on the active area will collapse and expand the comment.

If you collapse the comment while the action bar is expanded, the action bar is hidden with the comment but its expanded/collapsed state doesn't change. You can expand and collapse the action bar while the whole comment is collapsed, though you have to expand the comment to verify the state of the action bar.

Note that this active area includes the comment time indicator but not the username.

@Stugist
Copy link
Author

Stugist commented Jun 14, 2023

It took me about 6 tries after knowing how it was done to be able to get it to work. Basically press and hold. Bit tricky to do when you have sausage fingers.

@beatgammit
Copy link
Contributor

beatgammit commented Jun 14, 2023

Ok, apparently my phone was stuck on an older version (0.0.32) for some reason. I can now reproduce it, so I'll work on a fix. It looks like the main issue is that the default behavior is as if the checkbox was checked, so probably just a miss in the new version migration or something.

@beatgammit
Copy link
Contributor

I tracked it down, looks like a really easy fix. My change merely fixes the default behavior here, you can still disable the action bar in the settings. Whether that's desired is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - high priority This issue affects core functionality and must be fixed ASAP bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants