Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to remove and restore comments. #1182 #1323

Merged
merged 6 commits into from Jan 18, 2024
Merged

Adding ability to remove and restore comments. #1182 #1323

merged 6 commits into from Jan 18, 2024

Conversation

dessalines
Copy link
Member

This adds the ability to remove and restore comments.

It also adds the correct hierarchical logic for the canMod function copied from lemmy-ui, which requires a list of admins and mods.

dessalines
dessalines commented Jan 9, 2024
View reviewed changes
Copy link
Member Author

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan on adding more mod-abilities to jerboa in the coming weeks, but this is a good start.

app/src/main/java/com/jerboa/Utils.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/model/RemoveViewModel.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentOptionsDropdown.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/person/PersonProfileActivity.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/remove/comment/CommentRemoveActivity.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/remove/comment/CommentRemoveActivity.kt Show resolved Hide resolved
MV-GH
MV-GH requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the functionality, not a mod somewhere but I'll take your word on it.

app/src/main/java/com/jerboa/model/RemoveViewModel.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentOptionsDropdown.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/remove/comment/CommentRemoveActivity.kt Show resolved Hide resolved
@dessalines dessalines mentioned this pull request Jan 11, 2024
Open
4 tasks
@dessalines
Copy link
Member Author

I've been using voyager.lemmy.ml to test. You can use my test admin account there:

username: dess_tester_3

pass: dess_tester_3dess_tester_3

@dessalines dessalines mentioned this pull request Jan 11, 2024
Merged
@dessalines dessalines requested a review from MV-GH January 11, 2024 23:50
@dessalines dessalines merged commit 47ee753 into main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV-GH MV-GH MV-GH approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dessalines @MV-GH