Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents posts from reloading when changing the comments sorting #1462

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

rodrigo-fm
Copy link
Contributor

@rodrigo-fm rodrigo-fm commented Mar 28, 2024

Description

When we sort the comments on the PostActivity, the post information is also fetched (instead of just the comments). This PR fixes this.

Before

before.mp4

After

after.mp4

Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! run ./gradlew formatKotlin to pass the linter

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx!

@dessalines dessalines requested a review from MV-GH March 29, 2024 13:24
@MV-GH MV-GH merged commit c398987 into LemmyNet:main Mar 29, 2024
1 check passed
@rodrigo-fm rodrigo-fm deleted the hotfix/prevent-post-reload branch March 29, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants