Add option to disable showing the bottom navigation bar #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Jun 5, 2023
| @@ -76,6 +77,7 @@ fun SimpleTopAppBar( | |||
| @Composable | |||
| fun BottomAppBarAll( | |||
| navController: NavController = rememberNavController(), | |||
| appSettings: AppSettings? = null, | |||
There was a problem hiding this comment.
Since showBottomNav is the only one that's necessary, just pass that in rather than all the settings. If it needs more settings in the future, we can pass in the whole thing.
|
Oops, accidentally merged this early. I'll fix that issue I mentioned. |
|
I do plan to keep adding various UI settings to customize the UI to my liking, so I think for the time being passing the whole AppSettings object isn't a bad idea, just to reduce the amount of refractors that are necessary for each incremental option. |
|
No problem, we can always change that back then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checkbox option to disable the bottom navigation bar throughout the app. Testing locally it seems to work correctly, including migrations.