Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetics improvements #424

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Aesthetics improvements #424

merged 6 commits into from
Jun 6, 2023

Conversation

pipe01
Copy link
Contributor

@pipe01 pipe01 commented Jun 5, 2023

  • Disabled autocorrection in the login form's instance field.
  • Added some padding to the top of the login button.
  • Set the status and navigation bar colors depending on the chosen theme.
    • Also set the navigation color depending on the bottom app bar visibility.

@pipe01 pipe01 requested a review from dessalines as a code owner June 5, 2023 21:01
@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

Could you please re-trigger the build? We can now see the logs.

@pipe01
Copy link
Contributor Author

pipe01 commented Jun 6, 2023

Not sure how to do that, sorry.

@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

Just force push after having made a change to the commit (with git commit --amend --date="$(date)" for example, or maybe git commit --amend --reset-author but I'm not 100% certain)

@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

Well, now you get a proper error output to work with :P Good luck!

@pipe01
Copy link
Contributor Author

pipe01 commented Jun 6, 2023

I don't see any errors though, only warnings... It seems like gradle crashed?

@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

From the logs:

  • What went wrong:
    Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

Yeah you're right. I suppose the build is too heavy/long for the current infra and it was either OOM killed or terminated because of execution time.

Edit: It turns out it crashed because of exhausted drive space (or inodes?)

@pipe01
Copy link
Contributor Author

pipe01 commented Jun 6, 2023

Oops lol, I'm just not sure what the issue is. It builds just fine on my machine.

@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

I deleted my previous comment because you re-triggering the build actually disclosed what the problem is: No space left on device. I guess the VPS drive (for CI or the root drive) is full. Not your fault, it was bound to happen sooner or later, if my guess is correct (that's an infra bug).

But for now, until someone goes fix it on the host, nobody can pass any CI checks.

@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

@twizmwazin Hey, do you think you could re-trigger this job on the CI please? :)

@twizmwazin
Copy link
Contributor

I don't think I have any special access to do that.

@pipe01
Copy link
Contributor Author

pipe01 commented Jun 6, 2023

There we go, now it's working

@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

There we go, now it's working

Yeah I suspect that someone in the infra team for Lemmy.ml logged on the VPS and made some room on the drive.

PS: you might want to re-sync your PR with upstream...

$ git remote add upstream https://github.com/dessalines/jerboa.git
$ git fetch upstream
$ git rebase upstream/main
$ git push -f

@dessalines
Copy link
Member

dessalines commented Jun 6, 2023

Sorry about the CI issues all, our runners have been pretty overloaded. Testing this now.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dessalines dessalines enabled auto-merge (squash) June 6, 2023 20:35
@dessalines dessalines merged commit a77c611 into LemmyNet:main Jun 6, 2023
1 check passed
@7heo
Copy link
Contributor

7heo commented Jun 6, 2023

Yaay! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants