In-app image viewer #444
Merged
In-app image viewer #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if you put the button in the top right and add a back button in the top left? just a suggestion |
|
Oops yeah sorry, the download button is on the top right, not top left. On the top left there's a back button as you said. |
|
I can't wait to see this in the app! Is all that's left waiting for a new version of Zoomable? |
|
Yup, and also any feedback @dessalines may have. |
dessalines
reviewed
Jun 8, 2023
app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt
Outdated
Show resolved
Hide resolved
|
I'm gonna try to add download notifications, and then this can be merged if there are no further issues. |
|
Nevermind, it's a big PITA, I'll do it later. It seems like the CI is having some trouble again though. |
twizmwazin
approved these changes
Jun 9, 2023
dessalines
approved these changes
Jun 9, 2023
|
@pipe01 thanks for all your great functionality that got merged to 0.33-alpha, the experience is improving in subtle but important ways! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a post's image is clicked on the home page, the full image will be opened in the image viewer, which has the usual pinch zoom and pan functionality. There's also a save button in the top right corner which will download the image to the device's pictures folder, and a back button on the top left.
Everything is working already, I'm just waiting for https://github.com/usuiat/Zoomable to release a new version which will include a couple features that I need.
Fixes #397