-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-app image viewer #444
In-app image viewer #444
Conversation
What if you put the button in the top right and add a back button in the top left? just a suggestion |
Oops yeah sorry, the download button is on the top right, not top left. On the top left there's a back button as you said. |
I can't wait to see this in the app! Is all that's left waiting for a new version of Zoomable? |
Yup, and also any feedback @dessalines may have. |
app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt
Outdated
Show resolved
Hide resolved
I'm gonna try to add download notifications, and then this can be merged if there are no further issues. |
Nevermind, it's a big PITA, I'll do it later. It seems like the CI is having some trouble again though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it out and seems to work well. It doesn't appear to work for images embedded in comments yet.
@pipe01 thanks for all your great functionality that got merged to 0.33-alpha, the experience is improving in subtle but important ways! |
Whenever a post's image is clicked on the home page, the full image will be opened in the image viewer, which has the usual pinch zoom and pan functionality. There's also a save button in the top right corner which will download the image to the device's pictures folder, and a back button on the top left.
Everything is working already, I'm just waiting for https://github.com/usuiat/Zoomable to release a new version which will include a couple features that I need.
Fixes #397