Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to login on Firefox for iOS #969

Closed
sseneca opened this issue Jul 14, 2020 · 24 comments
Closed

Unable to login on Firefox for iOS #969

sseneca opened this issue Jul 14, 2020 · 24 comments
Labels
bug Something isn't working

Comments

@sseneca
Copy link

sseneca commented Jul 14, 2020

Issue Summary

After pressing "Login", it loads forever but doesn't log in. I've tried turning off tracking protection etc. but it doesn't help. Works with iOS Safari though.

Steps to Reproduce

  1. I clicked login, and an endless spinner shows up.

Technical details

iOS 13.5

Firefox version 27.0

@sseneca sseneca added the bug Something isn't working label Jul 14, 2020
@dessalines
Copy link
Member

Version at the bottom?

Really tough to do this one with no logs or anything.

@sseneca
Copy link
Author

sseneca commented Jul 14, 2020

Sorry, I should have mentioned that this is on the main lemmy instance https://dev.lemmy.ml, not my own, so I don't have logs to attach. This has been happening for a while, before the current version 0.7.20 (I have never been able to log in with iOS Firefox, and have tried a few times for the past couple weeks).

@dessalines
Copy link
Member

The browser console logs would be most helpful, but I realize that's probably impossible on mobile. I can't think of a way I can test this because I don't have an iphone. You could try clearing cookies?

Any FF addons enabled? Since it works on other browsers on your phone, its not a network issue.

@sseneca
Copy link
Author

sseneca commented Jul 14, 2020

Clearing cookies doesn't seem to work. And Firefox on iOS can't install addons (as far as I know), Apple wouldn't allow it :/

I just tried on Firefox Focus and DuckDuckGo's own app, and it doesn't work there either. It's probably worth somebody trying it out on Chrome for iOS, too.

@rfwatson
Copy link

Tested this on Firefox 27, iOS 13.5.1 (iPad) - logging in seemed to work fine fwiw.

@dessalines
Copy link
Member

@sseneca Did you try it on another browser on your device? I'd thought you did.

@sseneca
Copy link
Author

sseneca commented Jul 17, 2020

yeah, I tried it on Safari, the normal Firefox app, Firefox Focus, and DuckDuckGo. Safari was the only one where it logged me in.

@dessalines
Copy link
Member

I'd need somebody with an iphone to help out with this, because I don't have one, and without browser logs, I can't see what's going on.

@yehia2amer
Copy link

I just tried to login and it’s working fine on firefox on ios & safari !
All iOS browsers are forced to use Webkit, so all of them should behave the same.
———
I am using iOS 14 Public beta so I don’t know if it is an apple related issue on older iOS versions.

@eiknat
Copy link
Contributor

eiknat commented Jul 18, 2020

someone in our discord was able to reproduce on Firefox 27, iOS 13.6. safari works fine. looking into debugging options.

@dessalines
Copy link
Member

Ah, so that's why its happening on multiple browsers, but not all on ios. They all have to use webkit. I guess this means for ios the browser is less relevant than whatever webkit is installed. I'm not sure if the iOS version will be all that relevant either.

@eiknat
Copy link
Contributor

eiknat commented Jul 18, 2020

@dessalines potentially worth checking the info for that user on the db? possible somehow it could be a URL issue like the one we just fixed with #990 . if so, the URL would need to be fixed manually since it's already inserted.

not sure why it wouldn't affect anyone else, but could potentially be an odd URL format that works outside of webkit

@dessalines
Copy link
Member

dessalines commented Jul 18, 2020

Maybe, but it'd probably be easier for them to just try and make a new account, and see if it works or not. Plus #990 was only a problem if they somehow spoofed the front end to disable that form validation.

@sseneca
Copy link
Author

sseneca commented Jul 19, 2020

I've tried this with two different accounts and it happens with both 🤔

@PorkrollPosadist
Copy link

PorkrollPosadist commented Jul 25, 2020

I just built and set up an local instance of Lemmy from HEAD (617d636), created an ordinary user account, and tried to log in using Firefox, Chrome, and Firefox focus. I was hoping to reproduce the bug and capture some debug information from the server side, but "unfortunately" everything seemed to work. I also tested logging into the main test instance (https://dev.lemmy.ml) with all three and didn't encounter any problems.

Software versions:

Firefox: 27.0 (18428)
Firefox Focus: 8.1.4
Chrome: 84.0.4147.71
iOS: 13.5.1
Device: iPhone X
Model Number: MQCP2LL/A

If anyone comes up with another test scenario, I can see if I can borrow the phone again and give something else a try.

@dessalines
Copy link
Member

No idea, as I don't have any console logs. You say you can't make a new account and log into it on dev.lemmy.ml either?

@sseneca
Copy link
Author

sseneca commented Jul 26, 2020

I have two accounts and cannot log in with either.

I just tried making a third account and it logged in fine. Logging out and logging back in also worked fine. Logging in with another browser also worked. But then trying to log in with my normal account still did not work.

@dessalines
Copy link
Member

And you've tried logging into those accounts on desktop, and it works fine?

@sseneca
Copy link
Author

sseneca commented Jul 26, 2020

yes, all accounts work on desktop

@eiknat
Copy link
Contributor

eiknat commented Nov 7, 2020

does this still happen with the new frontend? a few people were able to reproduce and it seems this is related to autofilling the field.

@sseneca
Copy link
Author

sseneca commented Nov 7, 2020

Logging in is working again for me, so I’m going to close this. Feel free to re-open if people are still having this problem.

iOS 14.2
FF version 29.1
dev.lemmy.ml v0.8.2

@sseneca sseneca closed this as completed Nov 7, 2020
@dessalines
Copy link
Member

It must've been the websocket timeout in the front-end then, which I tweaked in v0.8.2. Another person commented that their forever loading circles have stopped too . Sorry about that.

@eiknat
Copy link
Contributor

eiknat commented Nov 8, 2020

It must've been the websocket timeout in the front-end then, which I tweaked in v0.8.2. Another person commented that their forever loading circles have stopped too . Sorry about that.

our reproduction on this indicated it was related to auto-fill, so the password was filled in in the text box but the state wasn't actually set as the text box was filled before inferno was ready. it was sending the password to the API as null but the returned error wasn't in an expected format which was causing the infinite loading appearance:

[2020-11-03T20:30:22Z ERROR lemmy_server::websocket::handlers] Error during message handling missing field `password` at line 1 column 34

though it appears to be fixed with the FE updates, we might want to check for bugs with other auto-fill things like comment text boxes for add-ons like grammarly which is heavily used for accessibility reasons by non-english speakers.

@dessalines
Copy link
Member

Hrm... I always assumed that if inferno's showing you that component, that its already done all the lifecycle hooks necessary. The only thing I can think of is to add another null / empty check on the login submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants