F-Droid build not reproducible

[linsui]

diff.zip

Could you please take a look? Thanks!

[dessalines]

We've had this error before, but I've changed nothing about the signing. All I did was upgrade some dependencies. I'm sure it'll resolve itself like before: in a few releases, f-droid will start working again, and I'll still have changed nothing about the signing config.

[linsui]

It's not about the signing config. How do you build your apk?

[dessalines]

./gradlew assembleRelease

That also hasn't changed, and there's been working and broken f-droid builds before and after that.

[licaon-kter]

And again today, fyi https://gitlab.com/fdroid/fdroiddata/-/commit/c5375a76ae39f6f180c1ec15d2977b1138855e0f

difflog:
thumb34.log

[dessalines]

What usually causes these?

[linsui]

Different jdk versions, Android studio, or cache not cleaned. Which jdk do you use to build your apk?

[dessalines]

Uh oh, ./gradlew --version says I'm using:

JVM: 17.0.8.1 (Oracle Corporation 17.0.8.1+1)

Yet my java --version is:

openjdk 17.0.8.1 2023-08-24

Maybe these lines are incorrect? https://github.com/dessalines/thumb-key/blob/main/app/build.gradle#L54

[linsui]

Maybe the oracle jdk produce different binaries. Those lines are correct.

[dessalines]

Okay, it looks like doing this is the only true way to figure out what java is being used in the build process.

I'll try setting my JAVA_HOME explicitly to my openjdk version for the next build, and ensuring that it uses it for the process. What a mess.

[licaon-kter]

fyi 2.1.1 not RB either https://gitlab.com/fdroid/fdroiddata/-/commit/2060e300fb57f492478bd3fe94c309a03b63b71b

Difflog is the same as linked above :(

[dessalines]

Not sure what I should do to fix it. This one was built with openjdk 17 .

[licaon-kter]

36 was ok 🤷 https://gitlab.com/fdroid/fdroiddata/-/jobs/5227631297#L635

[linsui]

Hmm, insteresting...

[dessalines]

I upgraded to gradle 8.3 for that one, not sure what else I did to make that one work.

[licaon-kter]

@dessalines not only gradle, also these c194722

[licaon-kter]

again https://gitlab.com/fdroid/fdroiddata/-/jobs/5294738530#L1087 :(

fyi https://gitlab.com/fdroid/fdroiddata/-/commit/f10fc71a2df359d433fceb7979e3f6b75f2e27ce

[linsui]

2.5.2 is reproducible.

[dessalines]

Might have been the upgrade to gradle 8.4 , but I have no idea lol. I apologize for these.

[licaon-kter]

reopen https://monitor.f-droid.org/builds/log/com.dessalines.thumbkey/43#site-footer

will rebuild locally to see the diff

[licaon-kter]

Difflog:
thumb43.log

Local APK:
com.dessalines.thumbkey_43.apk.ZIP (remove .ZIP)

[linsui]

2.6.5 failed again.
diff.zip

[dessalines]

No idea what causes these. This one is even stranger since I update zero gradle deps: 2.6.4...2.6.5#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9

[licaon-kter]

https://gitlab.com/fdroid/fdroiddata/-/jobs/5964721139#L502 fyi

[licaon-kter]

at least it's a new error https://gitlab.com/fdroid/fdroiddata/-/jobs/6133897492#L566

[licaon-kter]

https://gitlab.com/fdroid/fdroiddata/-/jobs/6145358484#L600

Only in /tmp/tmp2thsd9qi/tmp_binaries_com.dessalines.thumbkey_57.binary/content/assets: RELEASES.md

[linsui]

It's generated with https://github.com/dessalines/thumb-key/blob/main/generate_changelog.sh.

[dessalines]

I spose I just need to make sure that file is added to git then. I'll try that for the next release.

[dessalines]

Why did 2.6.15 fail? I added the missing file for that one.

[licaon-kter]

difflog:
thumb58.log

[dessalines]

I'm not sure how to read these, but it says that even things like ArrayList differ.

[linsui]

https://gitlab.com/fdroid/fdroiddata/-/jobs/6197859388

[quasipedia]

Is there anything that somebody with zero knowledge of Android coding can do to help here? The version on F-droid is lagging behind of more than 10 releases, and some critical bugs (like missing of letters from some layout) are still plaguing F-droid users... 😿

[licaon-kter]

I keep building newer versions locally, no success yet.

will rebuild latest asap

[licaon-kter]

new difflog:
thum65.log

[licaon-kter]

one good for now: https://gitlab.com/fdroid/fdroiddata/-/commit/f1f0d948f3fa27085f6e652d405219b27c4fd7ac

[dessalines]

Nice. Again I wish I knew what causes these.

[licaon-kter]

🤷 https://gitlab.com/fdroid/fdroiddata/-/commit/8fb6877c1ccca1b1756601972b9674d17a6d243a

[dessalines]

It fixed itself and we have no idea why lol. I'll take it.

[licaon-kter]

Don't jinx it now :)

[licaon-kter]

and :( again https://gitlab.com/fdroid/fdroiddata/-/jobs/6554341767#L547

[dessalines]

Not even a dep update with that one 🤷

[licaon-kter]

I'am just keeping you annoyedinformed :)

[licaon-kter]

@dessalines pls always build APK from Tagged commit, eg. https://github.com/dessalines/thumb-key/releases/tag/3.1.0 -> 1abe5ce

else https://gitlab.com/fdroid/fdroiddata/-/jobs/6702007748#L1257

not to mention that the commit is the one with the right versionCode and Name :(

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/a5c31f0211a2e46bff69c8b311aff68a614aca08

[dessalines]

Oops my bad. I'll reupload another one shortly.

Also:

git rev-list -n 1 3.1.0
1abe5ce59dfb9cd52aea5a5c5575259067efbee6