Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese compose layout #829

Closed
3 of 4 tasks
hiepoggy123 opened this issue Apr 7, 2024 · 2 comments
Closed
3 of 4 tasks

Vietnamese compose layout #829

hiepoggy123 opened this issue Apr 7, 2024 · 2 comments

Comments

@hiepoggy123
Copy link

Language

Vietnamese

Variant

Thumb-key compose

Kind of request

New Layout

More details

I really like this project. I'm not a coder so I just edited a little bit from ENThumbKeyCompose.

  • I added 5 vowels used in Vietnamese: "â" "ă" "ê" "ô" "ê" "ư".
  • Add vowel marks in Utils.kt file.
  • I couldn't upload the .kt file so I renamed it to .txt
    I may be foolish, wishing to be taught by you.
    Utils.txt
    VNThumbKeyCompose.txt

My English is quite poor so if you don't understand please forgive me.

Acknowledgements

  • I have written a short but informative title.
  • I have searched the existing layouts and issues to confirm that this layout either does not exist or was not requested already
  • I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements. 🤡
  • I have filled out all of the requested information in this form.
@hiepoggy123
Copy link
Author

hiepoggy123 commented Apr 10, 2024

@dessalines
I'm glad for your support.
There is a problem as follows:
In Vietnamese, there are 5 tone marks combined with vowels. For example:
à; á; ả; ã; ạ
I see a combination of vowels with the characters " "; " ' ".` in Utils.kt file.

There are 3 tone marks: "?" "." "~"

I am suggesting a change in the Utils.kt file by combining vowels with the character "?"; "*"; "~".

Could you consider this?

@dessalines
Copy link
Owner

dessalines commented Apr 10, 2024

Sure, go ahead. Now that the file is added, you can make a PR to the existing file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants