-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when using Japanese thumb-key #858
Labels
bug
Something isn't working
Comments
Confirmed crash on debug app, on a Xiaomi Redmi Note 8 Pro running MIUI 12 (android 11) Here's the stack trace:
|
glm4610
added a commit
to glm4610/thumb-key
that referenced
this issue
Apr 25, 2024
The bug was introduced in commit 0ab4b98 (Implement Drag-and-return & Circular drag (dessalines#854)). It was caused by an assumption that the numeric mode of a layout would have at least a one-to-one relation to its main or shifted modes. In this case, the Japanese main/shifted modes have more keys than the numeric mode, which caused an index error.
glm4610
added a commit
to glm4610/thumb-key
that referenced
this issue
Apr 25, 2024
The bug was introduced in commit 0ab4b98 (Implement Drag-and-return & Circular drag (dessalines#854)). It was caused by an assumption that the numeric mode of a layout would have at least a one-to-one relation to its main or shifted modes. In this case, the Japanese main/shifted modes have more keys than the numeric mode, which caused an index error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
1.activate japanese hiragana or katakana thumb-key.
2.open the keyboard.
Expected behavior
This should open japanese keyboard.
Actual behavior
the app crashes.
version of the program
3.1.0
Android version
Android 13
Device
Google Pixel 4
Other details
japanese type-split doesn't cause crash.
Acknowledgements
The text was updated successfully, but these errors were encountered: