Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother animation, notification on layout change and a bug fix #218

Merged
merged 3 commits into from
May 9, 2023

Conversation

sslater11
Copy link
Contributor

Smoother Animation
Hi, I have made the animation look smoother by fading it out. Before the animation would draw a box over the key and after it was finished, the box would instantly disappear. I've made both the box and the falling letter fade out at the end of the animation, which makes it look a lot less sharp. To test how smooth it looks, set both animation speeds to 500.
see KeyboardKey.kt for these changes

Layout change notification
I've added a Toast notification for every time the user changes the layout, so it will tell them which layout they are now on.
see ComposeKeyboardView.kt for these change.

Bug fix
The cursor was moving to the wrong place when we had a key that entered a string of text with more than one character.
Fixes issue 216.
see Utils.kt for the bug fix

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

In the future, run ./gradlew formatKotlin to pass lint.

@dessalines dessalines merged commit 6518a40 into dessalines:main May 9, 2023
1 check failed
@sslater11
Copy link
Contributor Author

Okay I can do that!
This is the first time I've worked with Kotlin code, so I'm not that great with it haha. I've been meaning to learn it, but it looks so different. It took me a lot longer than I care to admit to even figure out these tiny commits. The bug fix was easy at least lol.

Also, thank you very much for this app. I've been using "Mulitiling O Keyboard" with my own custom layout which is the same as this, but with a different letter arrangement as I did some analysis and thought I could improve on it. There is a speed limit with Multiling O, and your app allows multi touch which is awesome!

@dessalines
Copy link
Owner

I did the same... went from MessageEase -> MultiLing-O, and then both got abandoned.

I'm obsessed with typing speed, but I don't see us being able to get much faster without AI designed layouts: #169

@sslater11
Copy link
Contributor Author

Haha great minds aye! Personally I'm obsessed with the idea of being able to type perfectly without looking at my screen. I like the idea of being able to text and look around, or rudely text whilst someone else is talking to me, and I maintain eye contact lol.

For speed, one improvement I added was to not put any swiping letters on the middle key, because I noticed my thumbs battling it out. Instead I put the letters on the left and right side, and used symbols only in the middle.

Special keys for my layout:
Left side top button - shift key
Left side middle button - select all, copy, paste, cut
Left side bottom - swipe up/down/left/right = moving the cursor a single character. Swipe diagonal top left/right = move cursor by a whole word. Swipe diagonal bottom left right = move cursor to start/end of textbox.

Right side top button - delete
Right side middle button - enter
Right side bottom button - Swipe left/right = undo/redo
multilingo-my-layout-small

I obviously ported my layout to Thumb-Key, although I haven't put a Shift key on it yet lol. I'm struggling to write the letter j and z, because of the bug with the top row #issue #213, so I've been watching that. I also seem to struggle typing 'w' as I think I'm swiping slightly diagonally, but I'll adjust.
thumb-key-my-layout-small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants