Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog before resetting to default settings #390

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

storvik
Copy link
Contributor

@storvik storvik commented Sep 6, 2023

This pull request adds a simple confirmation dialog before resetting settings to default. I kept pressing the reset button accidentally.

Thanks for this project, love the idea!

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't necessary, but I spose I'm okay with it.

Run ./gradlew formatKotlin to pass lint.

@storvik
Copy link
Contributor Author

storvik commented Sep 6, 2023

@dessalines should be fixed now

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx!

@dessalines dessalines enabled auto-merge (squash) September 6, 2023 19:39
@dessalines dessalines merged commit 151b4ba into dessalines:main Sep 6, 2023
1 check passed
@storvik storvik deleted the reset-confirmation-dialog branch September 7, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants