Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lithuanian layout #395

Merged
merged 4 commits into from
Sep 10, 2023
Merged

lithuanian layout #395

merged 4 commits into from
Sep 10, 2023

Conversation

MariusTrap
Copy link
Contributor

No description provided.

@dessalines
Copy link
Owner

Check out some of the other language addition PRs. You need to add some things to Types.kt and Utils.kt

If you can't do this, lmk and I can.

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@MariusTrap
Copy link
Contributor Author

Changed Types.kt and Utils.kt. Didn't test anything.
Great concept and work.

@@ -156,6 +156,7 @@ enum class KeyboardLayout(val title: String, val index: Int) {
ThumbKeyHRv1Symbols("Thumb-Key hrvatski v1 with symbols", 58),
TypeSplitFIv1("Type-Split suomi v1", 59),
ThumbKeyLVLTGv1("Thumb-Key latviešu valoda v1", 60),
ThumbKeyLTv1("Thumb-Key lithuanian v1", 61),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the non-english form: lietuvių kalba

),
)

val THUMBKEY_EN_V4_SHIFTED = KeyboardC(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable name is wrong, make sure it compiles.

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx!

@dessalines dessalines merged commit f633ee7 into dessalines:main Sep 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants