Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mathematical keyboard layout #482

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

Kuna42
Copy link
Contributor

@Kuna42 Kuna42 commented Oct 12, 2023

Create a new keyboard layout for typing mathematical symbols.

The Keys are currently not sorted by frequency of use.
Those are sorted by similarity. ( As much as possible )
I would first try this layout out, so can you please mark it as an experimental layout?

create mathematical keyboard layout
@sslater11
Copy link
Contributor

When I saw this, I thought it was a calculator built into the keyboard and thought that was a great idea haha.

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

This is unused, you need to add it to the keyboard_definitions file too. Check the recent PRs.

And make sure you run ./gradlew formatKotlin to pass lint.

Add Mathematical layout to list of layouts, and formatted kotlin
Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@dessalines dessalines merged commit 277fd48 into dessalines:main Oct 13, 2023
1 check passed
@Kuna42
Copy link
Contributor Author

Kuna42 commented Nov 11, 2023

I tried to press all keys. But this characters appeared.

thumb_key_MATH-keyboard

@dessalines what could be wrong?

@dessalines
Copy link
Owner

I don't know what this character appeared means, but as you made this keyboard, I can't help you with it.

@sslater11
Copy link
Contributor

I saw this and wasn't sure what you meant either 😅.
Could you please explain the issue fully?

@Kuna42
Copy link
Contributor Author

Kuna42 commented Nov 23, 2023

Sorry for this bad explanation of my problem.
Later when i have more time left, i try to get a better description of my problem.

@Kuna42
Copy link
Contributor Author

Kuna42 commented Dec 24, 2023

Now, the problem should be fixed.
I didn't read the file correctly.
This Pull Request has know the things i missed the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants