fix inconsistent layout naming #497
Conversation
KraXen72
changed the title
KraXen72
changed the title
| @@ -781,7 +781,7 @@ val KB_UA_RU_MESSAGEEASE_SYMBOLS_SHIFTED = KeyboardC( | |||
| ) | |||
|
|
|||
| val KB_UA_RU_MESSAGEEASE_SYMBOLS: KeyboardDefinition = KeyboardDefinition( | |||
| title = "UA RU MessageEase український-русский with Symbols", | |||
| title = "RU MessageEase русский (RU+UA multi) symbols", | |||
There was a problem hiding this comment.
The ukrainian language code is UK : https://en.m.wikipedia.org/wiki/Ukrainian_language
There was a problem hiding this comment.
ah, okay. i see - i got confused, because i was using the ISO country codes, and not the language codes. i guess language codes make more sense, due to stuff like esperanto which is not tied to a country. will fix
| @@ -17,7 +17,7 @@ import com.dessalines.thumbkey.utils.KeyboardDefinitionModes | |||
| import com.dessalines.thumbkey.utils.SwipeDirection | |||
| import com.dessalines.thumbkey.utils.SwipeNWay | |||
|
|
|||
| val KB_UK_THUMBKEY_MAIN = KeyboardC( | |||
| val KB_UA_THUMBKEY_MAIN = KeyboardC( | |||
| @@ -109,7 +112,7 @@ enum class KeyboardLayout(val index: Int, val keyboardDefinition: KeyboardDefini | |||
| FITypeSplit(59, KB_FI_TYPESPLIT), | |||
| FRThumbKeyV1(8, KB_FR_THUMBKEY_V1), | |||
| FRThumbKeyV2(33, KB_FR_THUMBKEY_V2), | |||
| FRMessageEase(28, KB_FR_THUMBKEY_V1), | |||
| FRMessageEase(28, KB_FR_MESSAGEEASE), | |||
There was a problem hiding this comment.
Thx for getting this one. Eventually I'm going to put all these back in order by index, because people adding to this file need to see the last number anyway.
|
I'll fix these issues. I'll just use the UK language code for this, unless someone wants to differentiate them. |
|
Also in the future, do not use your main branch for development, use a feature-specific name. |
|
is the current state of the PR satisfactory? i want to get contribution credit 😛 (don't know kotlin yet, atleast i can help like this) |
|
You'll get the credit, don't worry :) In the future tho, you might want to set up a dev environment, it'd be much easier. |
|
thanks!! yeah this is about as far as i can go without one. |
i've implemented fixes for points 1, 3, 5, 6 and 7 of #495
symbols. before, some hadwith symbolsand some hadsymbolsUAand notUKKB_EOENDE_THUMBKEYlayout not being available in the layout picker (it wasn't imported)KB_FR_MESSAGEEASElayout to layout picker (reported in lemmy)about the other points in #495:
(i have not tested the changes, because i don't have android studio set up, but i was excruciatingly careful when modifying the files. please test that the affected layouts can be selected. i do want to set up android studio very soon though.)