Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeSplit Japanese Hiragana/Katakana #541

Merged
merged 10 commits into from
Nov 8, 2023
Merged

TypeSplit Japanese Hiragana/Katakana #541

merged 10 commits into from
Nov 8, 2023

Conversation

K0baU
Copy link
Contributor

@K0baU K0baU commented Nov 2, 2023

No description provided.

dessalines
dessalines requested changes Nov 2, 2023
View reviewed changes
Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed build, probably because of missing imports.

@K0baU
Copy link
Contributor Author

K0baU commented Nov 3, 2023

I used ENTypeSplit as a template. I didn't delete any import or use new variable. I have no idea what prevents build.

@dessalines
Copy link
Owner

I'll clean this one up and try to get it working when I do the next release, no need to do anything for now.

@dessalines dessalines enabled auto-merge (squash) November 8, 2023 14:36
@dessalines dessalines merged commit 0c09f11 into dessalines:main Nov 8, 2023
1 check passed
@K0baU K0baU deleted the patch-1 branch November 9, 2023 01:22
@Phidica Phidica mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@K0baU @dessalines