Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Japanese TypeSplit layouts #590

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Phidica
Copy link
Contributor

@Phidica Phidica commented Dec 18, 2023

Fixes problems that I described in #567. I made some other adjustments:

  • Put visually on the top of the key instead of on the right, to match the normal pattern of vowel sounds (I noticed that Gboard does it this way as well). Swiping to the right will still insert even though it's not visible.
  • Removed muted colours from the key which seemed to be accidentally left-over from copying the default English layout.
  • Put muted colours on the keys that only have punctuation, since this is similar to the use on the English layout. I left the centre symbol as non-muted but I don't really know for sure if it ought to be muted as well.

My logic when rearranging the "shifted" layouts was to make the dakuten/handakuten forms of characters line up with their normal forms whenever possible. With I preferred to put it close to orthogonally rather than diagonally. I moved the and = keys to appear as alternates of the other punctuation, and . I moved to the right side because already had to be moved there, and I thought they should stay on the same hand. This just left ¥ to be moved to the top left.

And everything I just said goes the same for the katakana.

Old New
Screenshot from 2023-12-18 23-55-00 Screenshot from 2023-12-18 23-51-03
Screenshot from 2023-12-18 23-55-05 Screenshot from 2023-12-18 23-51-09
Screenshot from 2023-12-18 23-55-15 Screenshot from 2023-12-18 23-51-16
Screenshot from 2023-12-18 23-55-21 Screenshot from 2023-12-18 23-51-26

@dessalines
Copy link
Owner

cc @K0baU

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets let @K0baU see if they agree with the changes. If they're unresponsive after a while, I'll just merge this as is.

@dessalines
Copy link
Owner

I'll merge now, and we can revert / add separate layouts later if kobau has any objections.

@dessalines dessalines merged commit df20e58 into dessalines:main Dec 19, 2023
1 check passed
@K0baU
Copy link
Contributor

K0baU commented Dec 20, 2023

I agree with your changes. When I create a Japanese layout, I try to follow the logic of its original (English) version. Since Japanese is different from English, this often causes a mismatch. I focus on making Japanese version available and am not fixing problems caused in this way. Problems fixed here are caused as a result of following the rule to put letters in a way similar to qwerty keyboard. For example, in qwerty, we have to type "ba" to input "ば", so I put "ば" where "b" is in qwerty. I did the same to other characters too. I agree that this is not a good idea, but submitted this layout because done is better than perfect. Thank you for improving the layout.

@K0baU
Copy link
Contributor

K0baU commented Dec 21, 2023

I clicked "revert" but it is unintended.

@Phidica Phidica deleted the jp-fix branch December 21, 2023 08:07
@Phidica
Copy link
Contributor Author

Phidica commented Dec 21, 2023

Ah I see, thanks @K0baU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants