Use messagease symbol layout for messagease number board #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested changes
Feb 8, 2024
app/src/main/java/com/dessalines/thumbkey/keyboards/ENMessageEaseSymbols.kt
Outdated
Show resolved
Hide resolved
Better match the [messagease layout](https://www.exideas.com/ME/iosfaq/numbers.png) Small variation from the real ME in that blank spaces have been filled with some of the extra math symbols that ME has on swipe-return keys, which we can't have on TK
|
I'll get this one merged before working on |
added 2 commits
February 9, 2024 13:56
See previous commit for image evidence
BlueDrink9
force-pushed
the
messageease_fix
branch
from
a75c780
to
ce8c62a
Compare
|
rebased to main and addressed review |
dessalines
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Why are there changes to this file, it was already added.
There was a problem hiding this comment.
Mentioned in my comment above, it didn't match the actual ME layout, + the extra symbols my version wanted didn't exist, so those have been added.
You can compare the image I linked if you care about the fidelity to messagease.
Otherwise if you'd prefer existing layouts remain set in stone, I'll create a variant
There was a problem hiding this comment.
Ah okay. We can always make corrections later anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the thumb-key numbers with messagease numbers (difference is in how symbols are positioned.) Better matches the messagease layout
Small variation from the real ME in that blank spaces have been filled with some of the extra math symbols that ME has on swipe-return keys, which we can't have on TK