Add Matrix-AMOLED theme #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested changes
Feb 9, 2024
README.md
Outdated
| @@ -173,6 +173,25 @@ To add a custom theme: | |||
| - Add a translation string in `strings.xml` for your theme name. | |||
| - Add the theme to the `colorPairs` in `Theme.kt` | |||
|
|
|||
| If you want to tweak your theme more precisely, these are the colours | |||
| that are used. Please keep the theme in line with [Material Design | |||
| Guidelines](https://m2.material.io/design/color/the-color-system.html) | |||
There was a problem hiding this comment.
These are the wrong guidelines, this uses m3, not m2.
|
You'll also need to install |
added 2 commits
February 12, 2024 19:35
|
Should now be good to go |
|
looks like CI failed because of a network error |
dessalines
approved these changes
Feb 12, 2024
|
I'll restart the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.