Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessagEase fixes #709

Merged
merged 5 commits into from
Feb 10, 2024
Merged

MessagEase fixes #709

merged 5 commits into from
Feb 10, 2024

Conversation

asdkant
Copy link
Contributor

@asdkant asdkant commented Feb 10, 2024

  • fixed the issues I introduced with the shared MessagEase numeric keyboard ("ME NumKB).
  • patched ME NumKB for better ergonomics on ME spanish keyboard

I wanted to open the PR as fast as possible to centralize discussion here, please keep this PR open while I work on the following:

  • do the same I did for the Es keyboard, but for EN keyboard

Related to this, I will also work (in another PR) on making "more symbols" variants for ES and EN keyboards, so people who like a super clean keyboard can have that and people like me who like a few more symbols at hand can have those

@asdkant
Copy link
Contributor Author

asdkant commented Feb 10, 2024

current EN keyboard

┏━━━┳━━━┳━━━┓
┃   ┃   ┃   ┃
┃ A ┃ N ┃ I ┃
┃  V┃ L ┃X  ┃
┣━━━╋━━━╋━━━┫
┃   ┃QUP┃   ┃
┃ HK┃COB┃MR ┃
┃   ┃GDJ┃   ┃
┣━━━╋━━━╋━━━┫
┃  Y┃ W'┃F  ┃
┃ T ┃ EZ┃ S ┃
┃   ┃,.-┃   ┃
┗━━━┻━━━┻━━━┛

how I intend to fix it:

┏━━━┳━━━┳━━━┓
┃   ┃   ┃   ┃
┃ A ┃ N ┃ I ┃
┃  V┃ L ┃X  ┃
┣━━━╋━━━╋━━━┫
┃   ┃QUP┃   ┃
┃ HK┃COB┃MR ┃
┃   ┃GDJ┃   ┃
┣━━━╋━━━╋━━━┫
┃  Y┃ W'┃F  ┃
┃ T ┃ EZ┃ S ┃
┃   ┃,.:┃   ┃
┗━━━┻━━━┻━━━┛

@BlueDrink9
Copy link
Contributor

I think hang off on this, because I have a big PR in the works that revamps creation of keyboards like numeric

@BlueDrink9
Copy link
Contributor

it looks like we have some very similar goals but we're approaching things differently. I'll look at your PRs, you should look at mine so we can coordinate

@asdkant
Copy link
Contributor Author

asdkant commented Feb 10, 2024

here's how it looks now:
Spanish lowercase:
ES-alpha-low
Spanish uppercase:
ES-alpha-up
Spanish numeric:
image

English lowercase:
image

English uppercase:
image

English numeric:
image

@asdkant
Copy link
Contributor Author

asdkant commented Feb 10, 2024

I think hang off on this, because I have a big PR in the works that revamps creation of keyboards like numeric

I just checked #700 and I'm fully on board with what you're doing.

This PR was intended as a "make my layout break my brain less right now" thing, it's a quick fix and it's already working (at least for what I desperately need in the very short term)

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx!

@dessalines dessalines merged commit fb54a4a into dessalines:main Feb 10, 2024
1 check passed
KeyC(
display = KeyDisplay.TextDisplay("±"),
action = KeyAction.CommitText("±"),
color = ColorVariant.MUTED,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 4 symbols too please, annoying to have these disappear on me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants