Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements on issue forms #717

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Enhancements on issue forms #717

merged 7 commits into from
Feb 12, 2024

Conversation

asdkant
Copy link
Contributor

@asdkant asdkant commented Feb 12, 2024

  • link to https://lemmy.ml/c/thumbkey in the
  • Rearranged checkboxes for bug/feature templates
  • added "I have updated the app" checkbox
  • added layout issue type (covers new layout and changes on an existing one)

You will need to create the "layout" label in https://github.com/dessalines/thumb-key/issues/labels

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx. But check the newlines, I'm guessing your editor wrongly added them.

- label: >-
I have searched the existing issues and this is a new one, **NOT** a duplicate or related to another open issue.
I have searched the existing issues and this is a new one, **NOT** a
duplicate or related to another open issue.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These newlines don't seem right.

Copy link
Contributor Author

@asdkant asdkant Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that was intentional, the >- indicates that it should all be parsed as a single line with no newline at the end.

see https://yaml-multiline.info/ for more info

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, that's unfortunate. Nothing we can do there I spose.

@dessalines dessalines merged commit 7f88288 into dessalines:main Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants