Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added standart english layout with german umlauts #818

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

philipp8101
Copy link
Contributor

hey, just discovered this app, seems like a really cool alternative to regular keyboards. (now i just have to get gud on it 馃槀)
i started out on the English layout, and rather stick with it, so i added the German symbols i need.
i tried it with the debug APK in the emulator, but i cant seem to find the new layout in the selection 馃槙
many thanks, Philipp

@dessalines
Copy link
Owner

There is already a ENDEThumbKey keyboard, did you try that out?

@philipp8101
Copy link
Contributor Author

Screenshot_20240329-151402.png

Screenshot_20240329-151416.png

Screenshot_20240329-151535.png

Hmm, I can't seem to find that in the app

@philipp8101
Copy link
Contributor Author

Have you considered, making the layouts simple configuration files, that can be loaded in at runtime.
Rather than compiling them in, and releasing a new version for every new layout.

@dessalines
Copy link
Owner

dessalines commented Mar 29, 2024

It's called english deutsch bilingual thumb-key.

All keyboard files must be compile-time checked, there are many issues about this.

@dessalines
Copy link
Owner

Also what version are you on?

@philipp8101
Copy link
Contributor Author

I'm on 2.6.9 that's the latest on f-droid.

@dessalines
Copy link
Owner

We're way past that, use either izzyondroid or github to get the newest version.

@philipp8101
Copy link
Contributor Author

I'm on 2.7.2 now, and have tried the layout you suggested. What I want is the same layout as "english thumb-key" but with the extra german letters.


val KB_EN_WITH_UMLAUT_THUMBKEY: KeyboardDefinition =
KeyboardDefinition(
title = "english thumb-key with german umlauts",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, in that case can you rename this like the other keyboard, but v2? Something like english deutsch thumb-key v2

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it for you.

@dessalines dessalines enabled auto-merge (squash) April 2, 2024 15:35
@dessalines dessalines merged commit d351918 into dessalines:main Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants