Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependancy to remove const error #18

Closed
wants to merge 1 commit into from

Conversation

netniV
Copy link

@netniV netniV commented Jun 30, 2020

This fixes the octokit error caused by the Toolkit GitHub action.

@thinkyhead
Copy link

Looking forward to this patch. In the meantime, I wonder if it works to use uses: netniV/lock-threads@patch-1? My first attempt seemed to fail silently. I'm about to give it another try….

@netniV
Copy link
Author

netniV commented Jul 6, 2020

I would think you'd need to specify using my specific version in your workflow file. However, don't quote me on that as whilst I think you can do, not entirely sure on that as I'm still learning the mysterious art of github actions one thing you could do is add the debugging to see any output.

@thinkyhead
Copy link

I used the path from above and when the job ran it gave this ("successful") result…
image

@netniV
Copy link
Author

netniV commented Jul 7, 2020

That’s interesting. If you turn on the debug etc. does it definitely pull in the later GitHub action sources ? They definitely fixed it in that one from what I read of the sources.

@dessant
Copy link
Owner

dessant commented Jul 7, 2020

Hi folks! Both package.json and package-lock.json need to be updated by running npm update @actions/github, and then the dist package pulled by workflows needs to be built with ncc by running npm run package. The last step should usually be done by maintainers for security reasons, since it produces a 1 MB file with a diff that is sometimes huge. I'll update all dependencies and release a new version today.

@dessant dessant closed this Jul 7, 2020
@netniV
Copy link
Author

netniV commented Jul 7, 2020

I did see that the other file needs to be updated but figured that was a security thing done by yourself. Glad to have it resolved though :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants