Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated node to 18, and ran audit fix to fix vulnerabilities. #133

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Updated node to 18, and ran audit fix to fix vulnerabilities. #133

merged 4 commits into from
Jun 18, 2023

Conversation

Riott
Copy link
Contributor

@Riott Riott commented Apr 28, 2023 •
edited

Updated node

Ran npm audit fix --force

Ran Unit Tests, all passing besides 3 failures which never passed for me prior so may be a local config issue or problem exists in master generally?

Resolves #131

11k
11k requested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update package-lock.json (probably deleting and recreating is the best approach) and the project's Dockerfile.

@Riott Riott requested a review from 11k May 9, 2023 09:07
@11k 11k added the enhancement New feature or request label Jun 18, 2023
@11k 11k merged commit 4caab0a into destinygg:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@11k 11k 11k approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js 14 is officially EOL at the end of April
2 participants
@Riott @11k