Add YouTube viewers to !live command #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #73 |
- Build command output in the !live command instead of within the twitch api service.
dotted
commented
Oct 13, 2020
lib/commands/implementations/live.js
Outdated
| } | ||
| const now = moment(); | ||
| const formattedDuration = formatDuration(moment.duration(now.diff(twitchStatus.started))); | ||
| const output = `Viewers: ${totalViewers}, TTV: ${twitchViewers}, YT: ${youtubeViewers}. Stream live as of ${formattedDuration} ago`; |
There was a problem hiding this comment.
Any suggestions to present this better are welcome
dotted
changed the title
dotted
commented
Oct 13, 2020
| if (searchCalled % 2 === 1) { | ||
| return Promise.resolve({ data: mockResponses.getActiveLiveBroadcastsVideoId }); | ||
| } | ||
| if (searchCalled % 2 === 0) { |
There was a problem hiding this comment.
This should be changed to something that isn't extremely fragile, but it works for now
|
I'm cool to merge this if you're satisfied with it. |
|
Seems I stopped short of actually handling an offline stream, now it just spits out 0 viewers instead of previous behavior. Let me just get that fixed first. |
- If only 1 stream is just post the total viewship
|
It looks GTG now, haven't tested the last commit with either a live youtube stream or both live twitch and youtube streams, but offline stream and an active twitch stream gives proper output. |
shadedred
reviewed
Oct 16, 2020
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made this for the memes, so if you end up not pulling this I wont be mad Abathur.
Only tested with
npm testusing Node 14, because Node 8 is simple too boomer even for me.Tasks:
betterderped way to mock YouTube responses so a test can be made for both when a stream is live and when there is no stream.