clean this up #211
clean this up #211
Conversation
| const banstruct = { | ||
| id: 0, | ||
| userid: 0, | ||
| username: '', | ||
| targetuserid: '', | ||
| targetusername: '', | ||
| ipaddress: '', | ||
| reason: '', | ||
| starttimestamp: '', | ||
| endtimestamp: '', | ||
| }; |
There was a problem hiding this comment.
I think we can do without this constant altogether. Can you just build the object in the method where it's used?
| ], | ||
| ]); | ||
|
|
||
| const settingsdefault = new Map([ |
There was a problem hiding this comment.
Would you mind building this, errorstrings, and helpstrings using an object? I'd prefer that over an array like this for better readability. You can use Object.entries() so its broken down into key-value pairs like the constructor expects.
| const regexslashcmd = /^\/([a-z0-9]+)[\s]?/i; | ||
| const regextime = /(\d+(?:\.\d*)?)([a-z]+)?/gi; | ||
| const nickmessageregex = /(?=@?)(\w{3,20})/g; | ||
| const nickregex = /^[a-zA-Z0-9_]{3,20}$/; |
There was a problem hiding this comment.
| const nickregex = /^[a-zA-Z0-9_]{3,20}$/; | |
| const nickregex = /^\w{3,20}$/; |
| const nsfwregex = /\b(?:NSFW)\b/i; | ||
| const nsflregex = /\b(?:NSFL)\b/i; |
There was a problem hiding this comment.
I think the non-capturing group is unnecessary for these two expressions. Would you mind removing them?
| const regextime = /(\d+(?:\.\d*)?)([a-z]+)?/gi; | ||
| const nickmessageregex = /(?=@?)(\w{3,20})/g; | ||
| const nickregex = /^[a-zA-Z0-9_]{3,20}$/; | ||
| const nsfwnsflregex = /\b(?:NSFL|NSFW)\b/i; |
There was a problem hiding this comment.
This regex and its related logic seems pointless because we already check for nsfw and nsfl separately in ignored(). I think its safe to remove.
| @@ -1,3 +1,21 @@ | |||
| const regexslashcmd = /^\/([a-z0-9]+)[\s]?/i; | |||
| const regextime = /(\d+(?:\.\d*)?)([a-z]+)?/gi; | |||
There was a problem hiding this comment.
I wasn't even aware there's support for decimal notation here. I think we can remove this to simplify things. I'm 100% positive nobody uses it.
| const regextime = /(\d+(?:\.\d*)?)([a-z]+)?/gi; | |
| const regextime = /(\d+)([a-z]+)?/gi; |
There's also the issue of commands that accept a time string succeeding when it's incorrectly formatted, but that's something we'll address in a future PR.
|
Just following up to see if you're interested in working through the issues I pointed out. I realize it could be more than you wanted to do. If you don't have the time, let me know and I'll have someone else work on this. |
whoever left it this way, think about your actions