Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax FSharp.Core and Serilog dependencies #13

Merged
merged 7 commits into from
Oct 30, 2019
Merged

Relax FSharp.Core and Serilog dependencies #13

merged 7 commits into from
Oct 30, 2019

Conversation

bartelink
Copy link
Contributor

@bartelink bartelink commented Oct 30, 2019

With the release of 1.1.0, I'm running into some conflicts when comparing with those imposed by using Destructurama.FSharp and Destructurama.FSharp.NetCore (for onloookers: which is an externally managed short term package) of the v 1.0.14 range

This applies a standard convention I've used with success across other projects (originally from Enrico and Dave in https://github.com/jet/falanx), whereby:

  • the impl package depends on a packages only as new as strictly required
  • test projects pull in newer versions as necessarily
  • applications are then free to float Serilog and FSharp.Core as desired

This also includes some more debatable tidying stuff - please push back and I can remove them

@baronfel
Copy link
Contributor

Lovely! Thank you for pushing through with this. One request: can you please add the upper bounds back on to the serilog dependency? It's a defensive habit to prevent breakages from major versions of dependent packages, and it narrows the search space for clients like paket.

I don't think it needs to be added for the fsharp.core dependency, because those are more and more being locked in by the SDK version you use.

@bartelink
Copy link
Contributor Author

FYI if you want to cross-validate, the smallest package I know of that applies this scheme is FsCodec. See https://github.com/jet/FsCodec/blob/master/src/FsCodec/FsCodec.fsproj

@bartelink
Copy link
Contributor Author

3.0 upper limit reinstated; good point (🤔 I should do some more of that)

@baronfel
Copy link
Contributor

Thanks for this 👍

@baronfel baronfel merged commit 103e1c1 into destructurama:dev Oct 30, 2019
@bartelink bartelink deleted the relax-fsharp-core-434 branch October 30, 2019 15:46
@TysonMN
Copy link
Contributor

TysonMN commented Mar 1, 2021

One request: can you please add the upper bounds back on to the serilog dependency? It's a defensive habit to prevent breakages from major versions of dependent packages [...]

Unfortunately, you didn't achieve that goal with the code

<PackageReference Include="Serilog" Version="[2.0.0, 3.0.0)" />

because this notation intentially includes all prereleases of 3.0.0, which might include breaking changes.

The only workaround that I know of is to instead use

<PackageReference Include="Serilog" Version="[2.0.0, 2.99]" />

or your favorite number of 9s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants