Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Standard 2.0 compatibility #4

Merged
merged 2 commits into from
Sep 20, 2017
Merged

.NET Standard 2.0 compatibility #4

merged 2 commits into from
Sep 20, 2017

Conversation

sirkirby
Copy link
Contributor

Added additional target for .NET Standard 2.0.

Other changes

  • Some additional suggested refactors from Resharper, which reduced the amount of code a bit.
  • Package updates

Functional changes

  • None

Breaking changes

  • None

@sirkirby
Add netstandard 2.0 to broaden compability
2c00fae 
- additional syntax refactoring based on resharper suggestions
- package updates
- set the dev version to 1.2
@nblumhardt
Copy link
Contributor

Hi Chris, thanks for the PR! Looks like there's a CI failure in there somewhere.

@sirkirby
Copy link
Contributor Author

@nblumhardt looks like an issue with the unit test assembly... I'll take a look

@sirkirby
Copy link
Contributor Author

sirkirby commented Sep 20, 2017 •
edited

got it... I added the netstandard2.0 target to the test project, however vs xunit test runner does not support .net standard. So removing that target should allow the test to run for netcoreapp1.1 and net452. For now, I think it's ok to leave it that way until they add support. A close alternative could be adding net461, which is standard 2 compatible, but honestly 452 should cover it... or we just move up from 452 to 461. I'll push the target removal first and see if that appeases appveyor :)

@sirkirby
removing netstandard2.0 target from test project
a84f8db 
- not currently supported by the xunit vs test runner
@nblumhardt nblumhardt merged commit bf40944 into destructurama:dev Sep 20, 2017
@nblumhardt
Copy link
Contributor

Great, thanks Chris! 👍

@nblumhardt nblumhardt mentioned this pull request Nov 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sirkirby @nblumhardt