Added control + c (copy) to message dialogs to copy text #373 #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we perhaps have this not as WXK_CONTROL_C but something like keys::copyKey() ? I'm just worried about in future if we have to abide to UX guidelines. |
|
What is keys::copyKey()? i dont see why this is such a big issue. If it needs to change we can always revisit it later. |
|
It's a hypothetical thing. Are we sure in the future we won't be adding more keybindings? |
|
If we did i think we would look into a solution that would be more generic than hard coded values. For now this is fine |
This was referenced Dec 22, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.