Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin entry when host is default. #18

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Fix plugin entry when host is default. #18

merged 1 commit into from
Jan 30, 2017

Conversation

fennecdjay
Copy link
Collaborator

PLUGIN="zsh-users/zsh-syntax-highligthing"
./zpm $PLUGIN
./zpm github.com/$PLUGIN

now properly use only "zsh-users/zsh-syntax-highligthing" as ~/.zpm/.plugin_list entry.

```sh
PLUGIN="zsh-users/zsh-syntax-highligthing"
./zpm $PLUGIN
./zpm github.com/$PLUGIN
```

now properly use only "zsh-users/zsh-syntax-highligthing" as ~/.zpm/.plugin_list entry.
@desyncr
Copy link
Owner

desyncr commented Jan 29, 2017

We'll have to review this functionality to properly work multi-host/host-agnostic.

There are various checks against github.com, github.com's length etc. We should target them. This is probably a huge task.

@fennecdjay
Copy link
Collaborator Author

I was thinking of having a config.h,
which would contain:

#define ZPM_DEFAULT_HOST "github.com"

in config.h.

we could then use

strlen(ZPM_DEFAULT_HOST)

mainly because I think there is a need for config.h since I read this

@desyncr
Copy link
Owner

desyncr commented Jan 29, 2017

Oh, yes. main source is already 413 lines. I'd like to have a lib/ directory with mostly helper functions. Having a config.h would be neat too :)

@desyncr desyncr added this to the 0.1.0 milestone Jan 29, 2017
Copy link
Owner

@desyncr desyncr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna merge this for now but before 0.1.0 we should be host agnostic.

@desyncr desyncr merged commit 18c8602 into desyncr:master Jan 30, 2017
@fennecdjay fennecdjay deleted the fix_add_item branch January 31, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants