Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: type hints for functions #14

Closed
wants to merge 2 commits into from

Conversation

yankeexe
Copy link
Contributor

@yankeexe yankeexe commented Apr 15, 2021

Updated type hints for the functions.

Few things I would like to get confirmed before I make the changes:
Reference: mypy Standard Duck Types

  1. Replace dict with typing.Mapping and typing.MutableMapping.
  2. Replace list and List with typing.Iterable and typing.Sequence.

I believe these changes will make the code more predictable.

@abdelhai abdelhai added help wanted Extra attention is needed investigating labels May 17, 2022
@lemonyte lemonyte mentioned this pull request May 17, 2022
@abdelhai abdelhai closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed investigating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants