Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: runtime: zip: fix the ignoring logic for top level directories #148

Merged
merged 1 commit into from Aug 30, 2023

Conversation

brkp
Copy link
Member

@brkp brkp commented Aug 29, 2023

Before this patch, if the user's project was located in a folder configured to be ignored by the .spaceignore file, Space CLI would ignore all of the files and try uploading an empty zip file.

This patch makes it so that ignore rules are only applied to files in the project folder.

@aavshr aavshr merged commit 7969567 into main Aug 30, 2023
1 check passed
@aavshr aavshr deleted the brkp/fix-zip-ignoring-logic branch August 30, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants