Merge pull request #16 from steeve-christen/bug/error-handler-notice-…

…converting-array-to-string Handled notice about $error that cannot be converted to string.
detailnet · Nov 20, 2015 · 2872ae6 · 2872ae6
2 parents bb786ca + 6af7e54
commit 2872ae6
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/Denner/Client/Subscriber/ErrorHandler.php b/src/Denner/Client/Subscriber/ErrorHandler.php
@@ -32,15 +32,17 @@ protected function getErrorMessage(Response $response)
         $error = $response->getReasonPhrase(); // e.g. "Bad Request"
 
         try {
-            // We might be able to fetch an error message from the response
-            $responseData = $response->json();
+            if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {
+                // We might be able to fetch an error message from the response
+                $responseData = $response->json();
 
-            if (isset($responseData['title'])) {
-                $error = $responseData['title'];
-            }
+                if (isset($responseData['title'])) {
+                    $error = $responseData['title'];
+                }
 
-            if (isset($responseData['detail'])) {
-                $error .= ': ' . $responseData['detail'];
+                if (isset($responseData['detail'])) {
+                    $error .= ': ' . $responseData['detail'];
+                }
             }
         } catch (ParseException $e) {
             // Do nothing