a few changes from calling halt to haltmsg to prevent actual halting

detain · Aug 2, 2018 · 2555dd2 · 2555dd2
1 parent 3c005eb
commit 2555dd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Mysqli/Db.php b/src/Mysqli/Db.php
@@ -271,8 +271,9 @@ public function seek($pos = 0) {
 		} else {
 			$this->haltmsg("seek({$pos}) failed: result has ".$this->num_rows().' rows', __LINE__, __FILE__);
 			/* half assed attempt to save the day, but do not consider this documented or even desirable behaviour. */
-			@mysqli_data_seek($this->queryId, $this->num_rows());
-			$this->Row = $this->num_rows;
+			$rows = $this->num_rows();
+			@mysqli_data_seek($this->queryId, $rows);
+			$this->Row = $rows;
 			return false;
 		}
 		return true;

diff --git a/tests/Mysqli/DbTest.php b/tests/Mysqli/DbTest.php
@@ -117,7 +117,7 @@ public function testQuery() {
 		$this->db->next_record(MYSQLI_ASSOC);
 		$second_id = $this->db->Record['st_id'];
 		$this->assertNotEquals($first_id, $second_id);
-		$this->assertTrue($this->db->seek(100000));
+		$this->assertFalse($this->db->seek(100000));
 		$this->db->next_record(MYSQLI_ASSOC);
 		$second_id = $this->db->Record['st_id'];
 		$this->assertNotEquals($first_id, $second_id);