Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect os_handler() signature #17

Closed
henninglive opened this issue May 18, 2017 · 0 comments
Closed

Incorrect os_handler() signature #17

henninglive opened this issue May 18, 2017 · 0 comments

Comments

@henninglive
Copy link
Contributor

henninglive commented May 18, 2017

The nix os_handler() needs be declared extern “C” since it is being called from libc. The current signature expects the rust calling convention, but it is being called with the C calling convention. This doesn’t crash on x64 or ARM where both C and rust pass the first arguments in registries, but will probably crash on x86 where C passes all arguments on the stack. Also, the register order is probably different, so the sig argument is probably invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant