This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Add missing boolean flags to Project Extension #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
reviewed
Jun 1, 2021
| @@ -6,6 +6,8 @@ plugins { | |||
| detekt { | |||
| debug.set(true) | |||
| isEnabled.set(true) | |||
| allRules.set(true) | |||
| parallel.set(true) | |||
There was a problem hiding this comment.
Do we want these enabled? Gradle give us the parallelism and active all the rules seems like too much
There was a problem hiding this comment.
This was just for a test as it's on the example project that contains 5 lines of code.
I'm fine turning both of them off.
BraisGabin
approved these changes
Jun 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure
detekt-compiler-pluginhas a feature set as close as possible to the Gradle plugin.Therefore I'm adding
allRules,parallelanddisableDefaultRuleSetsfrom the Detekt extension.