This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Make build Windows compatible #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
approved these changes
Oct 8, 2022
plugin-build/build.gradle.kts
Outdated
| args("\"plugin:detekt-compiler-plugin:debug=true\"") | ||
| } else { | ||
| executable(file("${unzipKotlinCompiler.get().destinationDir}/kotlinc/bin/kotlinc")) | ||
| args("plugin:detekt-compiler-plugin:debug=true") |
There was a problem hiding this comment.
nit: I would set these strings on a common variable and add the .bat and \" for the windows version. This way we can keep them aligned a bit easier.
3flex
force-pushed
the
windows-build
branch
2 times, most recently
from
1692b3c
to
f368c69
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.